Paolo Bonzini <pbonz...@redhat.com> writes:
> From: Wenchao Xia <wenchaoq...@gmail.com>
>
> Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are
> related, convert them in one patch. The block_job_event_* functions
> are used to keep encapsulation of BlockJob structure.
>
> Signed-off-by: Wenchao Xia <wenchaoq...@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
This broke tests/qemu-iotests/040. Apparently, the BLOCK_JOB_READY
event changed from
{'timestamp': {'seconds': 1403791120, 'microseconds': 539716},
'data': {'device': 'drive0',
'type': 'commit',
'speed': 0,
'len': 1048576,
'offset': 1048576},
'event': 'BLOCK_JOB_READY'}
to just
{'timestamp': {'seconds': 1403790920, 'microseconds': 123232},
'data': {'device': 'drive0'},
'event': 'BLOCK_JOB_READY'}
breaking qemu-iotests/040's tests of data/type and data/len.
Documentation of BLOCK_JOB_READY shows only data/device, before and
after this patch.
Suggests that
* Before this patch, code disagreed with docs, and qemu-iotests/040
matched the code.
* After this patch, code matches docs, and qemu-iotests/040 matches
neither.
Please advise.
