On Thu, 26 Jun 2014 17:50:08 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> Paolo Bonzini <pbonz...@redhat.com> writes: > > > This includes: > > > > - Max's dependency fixes for QAPI scripts > > > > - Wenchao's QAPI event series > > > > - my thread-safety fixes, rebased onto QAPI events > > The QAPI event series messed up two out of three event types tested in > qemu-iotests, if I count them correctly. Let's fix 'em. > > How can we gain confidence that we're not breaking half of the events > not tested there, too? Let's test 'em. It would be superb to add tests for them. I tested most of them myself before applying the series, but it was a manual test. I didn't check/test every single field of every single event.