Il 28/07/2014 11:54, Pavel Dovgaluk ha scritto: >>> > > + VMSTATE_TIMER_V(timer, RTL8139State, 5), >> > >> > timer need not be migrated, because it is reinstated by rtl8139_post_load. >> > > That's true for normal execution. > In replay execution mode post_load can be called before cached virtual clock > values are loaded. This may cause invalid setting of the timer and raising > an IRQ which didn't happen in record mode. > I will update this patch to fix post_load function and avoid this > non-deterministic behavior.
This is what worries me of this series. These invariants are not documented anywhere, and people will break them unless you add assertions that also hold in normal mode. Paolo
