On Mon, 2014-08-18 at 15:54 +0800, zhanghailiang wrote: > The function fopen() may fail, so check its return value. > > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > Signed-off-by: Li Liu <john.li...@huawei.com> > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > --- > tests/bios-tables-test.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 045eb27..feb3b58 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -790,6 +790,11 @@ int main(int argc, char *argv[]) > const char *arch = qtest_get_arch(); > FILE *f = fopen(disk, "w"); > int ret; > + > + if (!f) { > + fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno)); > + return -1; > + } Hi, I think we should use an assert here, we need an indication that the test failed and a print to stderr is not enough.
Thanks, Marcel > fwrite(boot_sector, 1, sizeof boot_sector, f); > fclose(f); >