On Mon, Aug 18, 2014 at 03:38:12PM +0400, Michael Tokarev wrote: > 18.08.2014 11:54, zhanghailiang wrote: > > The function fopen() may fail, so check its return value. > > > > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > > Signed-off-by: Li Liu <john.li...@huawei.com> > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > > --- > > tests/bios-tables-test.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > > index 045eb27..feb3b58 100644 > > --- a/tests/bios-tables-test.c > > +++ b/tests/bios-tables-test.c > > @@ -790,6 +790,11 @@ int main(int argc, char *argv[]) > > const char *arch = qtest_get_arch(); > > FILE *f = fopen(disk, "w"); > > int ret; > > + > > + if (!f) { > > + fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno)); > > + return -1; > > + } > > Applied to -trivial, with s/-1/1/. No need to resend it again. > > Thanks, > > /mjt > > > fwrite(boot_sector, 1, sizeof boot_sector, f); > > fclose(f); > > > >
This doesn't seem appropriate to trivial tree: there were some objections from Marcel, I'd like to see them addressed.