Re: [Qemu-devel] [PULL 3/3] vnc: fix screen updates

[Zhang Haoyu]

>Bug was added by 38ee14f4f33f8836fc0e209ca59c6ae8c6edf380.
>vnc_jobs_join call is missing in one code path.
>
>Reported-by: Anthony PERARD <anthony.per...@citrix.com>
>Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
>---
> ui/vnc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/ui/vnc.c b/ui/vnc.c
>index 6c9d4f3..aac93f0 100644
>--- a/ui/vnc.c
>+++ b/ui/vnc.c
>@@ -935,6 +935,9 @@ static int vnc_update_client(VncState *vs, int has_dirty, 
>bool sync)
>         }
> 
>         vnc_job_push(job);
>+        if (sync) {
>+            vnc_jobs_join(vs);
>+        }
>         vs->force_update = 0;
>         return n;
>     }
>-- 
>1.8.3.1

What about below raw patch,
@@ -935,14 +935,13 @@ static int vnc_update_client(VncState *vs, int has_dirty, 
bool sync)
         }
 
         vnc_job_push(job);
         vs->force_update = 0;
-        return n;
     }

     if (vs->csock == -1) {
         vnc_disconnect_finish(vs);
     } else if (sync) {
         vnc_jobs_join(vs);
     }

-    return 0;
+    return n;

Thanks,
Zhang Haoyu