On Fri, Feb 12, 2010 at 02:55:56PM -0600, Adam Litke wrote: > Arghh... Adding missing S-O-B > > Hi Anthony. I wonder if there was a problem when importing my async > command handler patchset. Since the 'balloon' command completes > immediately, it must call the completion callback before returning. > That call was missing but is added by the patch below. > > Signed-off-by: Adam Litke <a...@us.ibm.com> > > diff --git a/monitor.c b/monitor.c > index ae125b8..f94794d 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params, > return -1; > } > > + cb(opaque, NULL); > return 0; > } > > --
Can we get this patch applied to GIT - without it, QEMU just hangs under libvirt immediately, since we nearly always issue a balloon command at start Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
