Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command

[Anthony Liguori]

On 02/22/2010 10:51 AM, Adam Litke wrote:

This patch application failed. My patch adds a cb() call in
do_balloon(), but the change in git has added the cb() call to
do_info_balloon().  That is causing qemu segfaults.  Applying the
following should correct the damage.  Thanks.

Fix for commit: 5c366a8a3d7ac71beda8499caa815cb3ea95eb58

The cb() call is needed in do_balloon(), not do_info_balloon().

Signed-off-by: Adam Litke<a...@us.ibm.com>

Applied.  Thanks.

Regards,

Anthony Liguori

diff --git a/monitor.c b/monitor.c
index b1a6edc..c7d2117 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2309,7 +2309,6 @@ static int do_info_balloon(Monitor *mon, 
MonitorCompletion cb, void *opaque)
          return -1;
      }

-    cb(opaque, NULL);
      return 0;
  }

@@ -2332,6 +2331,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
          return -1;
      }

+    cb(opaque, NULL);
      return 0;
  }