04.12.2014 14:59, Thomas Huth wrote: >> >> Ping? > > Ping again
Thomas, we was in freeze trying to get 2.2 out of the door. During this time I didn't process -trivial patches, to not pollute incoming changes stream even further. Your patch for some reason does not apply to current state of get_maintainer.pl script, failing this hunk: >>>> - foreach my $chief (@penguin_chief) { >>>> - if ($chief =~ m/^(.*):(.*)/) { >>>> - my $email_address; >>>> - >>>> - $email_address = format_email($1, $2, $email_usename); >>>> - if ($email_git_penguin_chiefs) { >>>> - push(@email_to, [$email_address, 'chief penguin']); >>>> - } else { >>>> - @email_to = grep($_->[0] !~ /${email_address}/, @email_to); >>>> - } >>>> - } >>>> - } >>>> - I didn't look at the details, because this is a trivial delete of a block of code, so I just deleted it manually. So I applied your patch now. Note there's one more reference to penguin chief left in the code, in get_maintainer_role function. I don't think it is wrong. Thanks, /mjt