On 18/02/2015 22:09, Programmingkid wrote:
> + # Take an image and make the image its own icon:
> + sips -i ../pc-bios/qemu-nsis.ico
> + # Extract the icon to its own resource file:
> + DeRez -only icns ../pc-bios/qemu-nsis.ico > tmpicns.rsrc
IIUC sips modifies ../pc-bios/qemu-nsis.ico (adding a resource fork?),
so it's not possible to put it in Makefile.target. If "sips" is invoked
twice by two different recursive invocations of Makefile.target, bad
things can happen.
I think we can simply distribute tmpicns.rsrc as pc-bios/qemu.rsrc instead.
> + # append this resource to the file you want to icon-ize.
> + Rez -append tmpicns.rsrc -o $(QEMU_PROG)
> +
> + # Use the resource to set the icon.
> + SetFile -a C $(QEMU_PROG)
These two commands can be added after
$(QEMU_PROG_BUILD): $(all-obj-y) ../libqemuutil.a ../libqemustub.a
$(call LINK,$^)
instead of adding a new rule. There is no need for the comments.
Paolo
