On 19 February 2015 at 18:56, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 18/02/2015 22:09, Programmingkid wrote: >> + # Take an image and make the image its own icon: >> + sips -i ../pc-bios/qemu-nsis.ico >> + # Extract the icon to its own resource file: >> + DeRez -only icns ../pc-bios/qemu-nsis.ico > tmpicns.rsrc > > IIUC sips modifies ../pc-bios/qemu-nsis.ico (adding a resource fork?), > so it's not possible to put it in Makefile.target. If "sips" is invoked > twice by two different recursive invocations of Makefile.target, bad > things can happen. > > I think we can simply distribute tmpicns.rsrc as pc-bios/qemu.rsrc instead.
Why not just use the sips --out option to specify a different output file? That way we automatically put the current icon into the executable, and don't have to update a hand-created qemu.rsrc file in git if we change the icon in future (and I bet if we don't have the rules for doing this in the makefile then nobody will remember how to do it). As a bonus we don't have to keep that file full of ugly high-bit-set characters in C comments in git :-) -- PMM