Eric Blake <ebl...@redhat.com> writes: > In the testsuite, UserDefTwo and UserDefNested were identical > types other than the member names. Reduce code duplication by > having just one type, and choose names that also favor reuse. > This will also make it easier for a later patch to get rid of > inline nested types in QAPI; it means that the type is now boxed > instead of unboxed in C code, but has no difference to the QMP > wire protocol.
I can't see a change from boxed to unboxed in this patch. Does the remark apply to the elimination of nested types? If yes, it's premature here. > When touching code to add new allocations, also > convert existing allocations to consistently prefer typesafe > g_new0 over g_malloc0. I can't see any change from g_malloc0() to g_new0(). Is this stale? > > Ensure that 'make check-qapi-schema check-unit' still passes. > > Signed-off-by: Eric Blake <ebl...@redhat.com>
