Am 08.05.2015 um 19:18 schrieb Paolo Bonzini: > On 08/05/2015 19:10, Andreas Färber wrote: >>> Error *err = NULL; >>> Object *obj; >>> obj = object_new_propv(TYPE_MEMORY_BACKEND_FILE, >>> "/objects", >> >> This is not an Object*. ;) I like it better as it's implemented below, >> but cf. above for mixing this Error**-ing operation with object_new(). > > Right, this was my main request on review
Hm, didn't make it to the list then...? Only the one reply to 0/7. Andreas > and I had fixed up the commit > message in the pull request. > > I'm certainly okay with a separate object_set_props function (better: > object_parse_props) and object_parse_propv for the va_list case. > > Paolo -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)