On 06/08/2015 12:57 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > include/monitor/qdev.h | 2 +- > qdev-monitor.c | 36 +++++++++++++++--------------------- > vl.c | 7 +++++-- > 3 files changed, 21 insertions(+), 24 deletions(-) >
> if (!object_dynamic_cast(OBJECT(bus), dc->bus_type)) {
> - qerror_report(ERROR_CLASS_GENERIC_ERROR,
> - "Device '%s' can't go on a %s bus",
> - driver, object_get_typename(OBJECT(bus)));
> + error_setg(errp, "Device '%s' can't go on a %s bus",
> + driver, object_get_typename(OBJECT(bus)));
Pre-existing - "a '%s' bus" or "an %s bus" might look a bit nicer than
"a %s bus" for some bus names (depends on the initial sound during
pronunciation). Certainly a nightmare for translation rules to other
languages that don't follow English rules on indefinite article usage.
Maybe some word-smithing can avoid the indefinite article altogether?
But not something I care about enough to hold up the series.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
