Re: [Qemu-devel] [PATCH 13/16] ahci: add get_cmd_header helper

[Stefan Hajnoczi]

On Mon, Jun 22, 2015 at 08:21:12PM -0400, John Snow wrote:
> +static AHCICmdHdr *get_cmd_header(AHCIState *s, uint8_t port, uint8_t slot)
> +{
> +    if (port > s->ports || slot > AHCI_MAX_CMDS) {

Should these be >= instead of >?  Otherwise 1 element beyond the end of
the array can be accessed.

pgph0i97yAZyA.pgp
Description: PGP signature