Re: [Qemu-devel] [PATCH 16/16] ahci: fix sdb fis semantics

[Stefan Hajnoczi]

On Mon, Jun 22, 2015 at 08:21:15PM -0400, John Snow wrote:
> @@ -682,19 +680,22 @@ static void ahci_write_fis_sdb(AHCIState *s, int port, 
> uint32_t finished)
>  
>      sdb_fis->type = SATA_FIS_TYPE_SDB;
>      /* Interrupt pending & Notification bit */
> -    sdb_fis->flags = (ad->hba->control_regs.irqstatus ? (1 << 6) : 0);
> +    sdb_fis->flags = 0x40; /* Interrupt bit, always 1 for NCQ */
...
> -    ahci_trigger_irq(s, ad, PORT_IRQ_SDB_FIS);
> +    if (sdb_fis->flags & 0x40) {
> +        ahci_trigger_irq(s, ad, PORT_IRQ_SDB_FIS);
> +    }

This if statement is always true.

pgpjA8LnN1K3E.pgp
Description: PGP signature