On 12.05.2010, at 19:28, Aurelien Jarno wrote: > On Tue, May 11, 2010 at 09:50:34PM +0200, Alexander Graf wrote: >> >> Am 11.05.2010 um 19:26 schrieb Richard Henderson <r...@twiddle.net>: >> >>> On 05/11/2010 09:47 AM, Stefan Weil wrote: >>>> Won't you get another warning about unreachable code >>>> because tcg_abort never returns? >>> >>> We don't enable that warning. >>> >>>> What about condition compilation for tcg_out_reloc >>>> (don't compile it for hosts which don't need it)? >>> >>> All hosts should need it. S390 doesn't only because >>> it's all stubbed out. >>> >>> Frankly, it shouldn't take much effort to get a working >>> TCG for s390x... >> >> Yeah, I have submitted a patch months ago, but Aurelien didn't get >> around to review it yet :(. >> > > This is indeed the best solution. It's still on my TODO list, just that > I have limited time and it's always easier to choose to ignore one big > patch and got complains from a single person, than ignoring a lot of > small patches and getting a lot of complains...
I can split up the patch if you like :). > If only people were reviewing other people patches a bit more... Maybe Richard could also help to review it? If so, I can certainly rebase it to current git and send it off again. Alex