On 12 August 2015 at 17:40, Paolo Bonzini <pbonz...@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
>  translate-all.c | 29 ++++++++++++++++++++++-------
>  1 file changed, 22 insertions(+), 7 deletions(-)

Some overall documentation on what the mmap_lock is protecting
(and thus when it needs to be taken) would be nice.

Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>

I couldn't see where we take the mmap_lock when we call
tb_gen_code() from tb_find_slow() -- how does that work?

thanks
-- PMM

Reply via email to