On 8 September 2015 at 20:28, Richard Henderson <r...@twiddle.net> wrote: > On 09/08/2015 12:06 PM, Peter Maydell wrote: >> On 8 September 2015 at 20:00, Richard Henderson <r...@twiddle.net> wrote: >>> On 09/08/2015 11:56 AM, Peter Maydell wrote: >>>> My sparc test image (which is just the 32-bit debian from >>>> Aurelien's website) boots fine even with this patchset... >>> >>> Odd, it shouldn't. ;-) >>> >>> Anyway, I've just fixed the sparc problem and re-pushed the tree to >>> >>> git://github.com/rth7680/qemu.git tcg-search-2 >>> >>> for anyone who wants to do any more testing. >> >> ...so what was the bug? (Push doesn't seem to have made it >> to github yet.) > > Err.. it has. Tip should be 98cb3e2ecffd126177f43634b643be81bdc764e7. > So I guess you pulled it post fix?
Yep, that's what I've been reviewing...would explain why I couldn't get it to fall over in testing :-) > The problem was in 12/20, "target-sparc: Remove gen_opc_jump_pc". > > The original was slightly off in how it was computing the npc in a delay slot. > The replacement keeps the dc->jump_pc array, but verifies that the value of > dc->jump_pc[1] is as expected: jump false to next insn. It's a smaller change > to the translator, and easier to verify correctness. Yeah. My r-b applies to the fixed version, not the mail on the list. thanks -- PMM