On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf <kw...@redhat.com> wrote:
>> +{ 'command': 'x-child-add', >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > This is probably not future-proof and only made for the special case > of quorum. Specifically, one thing I'm missing is some way to specfiy > what kind of child the new node is when a node can take different > types of children (e.g. bs->file and bs->backing_hd). Children here are specified by child roles, aren't they? We could have a ChildRole enum with 'file', 'format' and 'backing' that would be passed to this command and use the same enumeration in bdrv_open_image() rather than a pointer to BdrvChildRole. Berto