Hi On Wed, Sep 23, 2015 at 2:10 PM, Claudio Fontana <claudio.font...@huawei.com> wrote: >> Let's change it for IVSHMEM_DPRINTF("use msix, present: %d\n", >> msix_present(d)); ok? >> > > what about something like > > IVSHMEM_DPRINTF("%susing MSI-X\n", msix_present(d) ? "" : "not "); > > or just > > if (!msix_present(d) { > IVSHMEM_DPRINTF("not using MSI-X"); > return; > } > > IVSHMEM_DPRINTF("using MSI-X");
I find it more confusing. ivshmem_use_msix() is the place where msix_vector_use() is called. However, ivshmem_has_feature(s, IVSHMEM_MSI) may be true or not. Only MSIX is effectively enabled if the guest has MSIX, which is what msix_present(d) says. So I would rather keep the last debug Iine I proposed (again this is just for debugging, when compiling with IVSHMEM_DEBUG, not a message that a user will ever see). thanks -- Marc-André Lureau