On 14 October 2015 at 23:55, Edgar E. Iglesias <edgar.igles...@gmail.com> wrote: > From: "Edgar E. Iglesias" <edgar.igles...@xilinx.com> > > Introduce ARMMMUFaultInfo to propagate MMU Fault information > across the MMU translation code path. This is in preparation for > adding Stage-2 translation. > > No functional changes. > > Signed-off-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > @@ -1774,9 +1775,10 @@ static uint64_t do_ats_write(CPUARMState *env, > uint64_t value, > bool ret; > uint64_t par64; > MemTxAttrs attrs = {}; > + ARMMMUFaultInfo fi = {};
Why are most of these initialized with "{}" ... > @@ -83,8 +83,9 @@ void tlb_fill(CPUState *cs, target_ulong addr, int > is_write, int mmu_idx, > { > bool ret; > uint32_t fsr = 0; > + struct ARMMMUFaultInfo fi = {0}; ...but this one uses "{0}" ? Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM