On Tue, Nov 10, 2015 at 09:07:20AM -0700, Eric Blake wrote: > On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple volfile servers to the gluster > > block backend of QEMU with tcp|rdma transport types and their port numbers. > >
[...] > > +/* > > +* > > +* Basic command line syntax looks like: > > +* > > You have 110 lines from /* to */. In v10, I already mentioned that this > comment is probably 100 lines too long. You do NOT need to repeat the > syntax, examples, or even more-readable example here; having them in the > commit body was enough. Someone that knows how to read qapi will be > able to deduce what this function is doing if you were to simplify to > just this: > > /* > * Convert the command line into qapi. > */ > Maybe a good compromise could be moving this into docs/gluster.txt (which doesn't exist, but could get its start this way!). That way, the info is there to read / find with grep without needing to look at commit logs. [...] -Jeff
