On Thu, Nov 12, 2015 at 11:23:35AM -0500, Jeff Cody wrote: > On Thu, Nov 12, 2015 at 05:04:02AM -0500, Prasanna Kumar Kalever wrote: > > On Tuesday, November 10, 2015 9:37:20 PM, Eric Blake wrote: > > > > > > On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to specify multiple volfile servers to the gluster > > > > block backend of QEMU with tcp|rdma transport types and their port > > > > numbers. > > > > > > > > > > [...] > > > > [...] > > > > > > > > Overall, I think we are probably on the right track for the QMP > > > interface; but since blockdev-add is NOT stable yet for 2.5, it won't > > > hurt to wait to get this in until 2.6, to make sure we have plenty of > > > time; and it would also be nice to make sure we get nbd, nfs, rbd, > > > sheepdog all supported in the same release; possibly by sharing common > > > types instead of introducing GlusterServer as a one-off type. > > > > We are hoping this to go in 2.5 which is really important for gluster > > hyper-convergence release (next Feb). > > > > Is there any possibility of getting exception for this patch ? > > > > Thanks, > > -Prasanna > > > > Today is the hard freeze for 2.5 for new features. As the v14 patches > hit the list today, I will review them, and if they look good I can > pull patches into my tree. > > Whether there is an exception is really up to Peter Maydell > (added him to the cc) - if all looks good with the patches, I could > send a pull request out later today with them, but that will be late > in the evening for Peter. >
I wanted to give a follow-up - as Eric pointed out in his reviews, the API interface could be made better by using some QAPI features that are not currently in qemu (discriminated unions). So I won't issue a pull request for this for 2.5, and we'll pick it up for 2.6 once the interface issues can be worked out. -Jeff