Eric Blake <ebl...@redhat.com> writes: > On 11/18/2015 01:53 AM, Eric Blake wrote: >> Add positive tests to qapi-schema-test for things that were >> made possible by recent patches but which caused compile errors >> due to collisions prior to that point. The focus is mainly on >> collisions due to names we have reserved for qapi, even though >> it is unlikely that anyone will want to abuse these names in >> actual .json files. >> >> The added tests includes: >> Use of a member name ending in 'Kind' or 'List' [1, 3] > > Violates our coding convention of all lower case, so not worth testing. > >> Use of a type name starting with 'has_' [1, 4] > > Ditto. > >> Use of a type named 'u' [1, 5] > > Ditto. > >> Use of a union branch name of 'u' [2, 5] >> Use of a union branch name starting with 'has_' [2, 4] > > Leaving just these two feels pretty weak. I think I'll just drop this > patch from my queue entirely (it was great at proving that recent layout > improvements worked, but it's not the end of the world to lose it > entirely, especially now that v13 is starting to enforce naming > conventions except for a few whitelisted names, and I don't want to make > the whitelist longer just for the testsuite).
Makes sense. [...]
