Le 18/12/2015 23:12, Chen Gang a écrit : > > On 12/19/15 05:58, Laurent Vivier wrote: >> >> Le 18/12/2015 22:40, Chen Gang a écrit : >>> > > [...] > >>> I did not get any script/checkpatch.pl complains, originally. >>> >>> Does my email client configuration is incorrect, then cause incorrect >>> mail format? I guess not. The related reason is below. >>> >>> - I copy your full reply mail contents to a new file (diff.patch). >> >> If you copy, you loose the special characters. I do a "Save as". >> >>> >>> - Remove all '> ' in vi editor (1,% s/^> //g) (so get the original >>> patch contents). >>> >>> - ./script/checkpatch.pl diff.patch, it has no any complains. >> >> If I run "file" on the saved file, I have: >> >> $ file orig.eml >> orig.eml: SMTP mail, ASCII text, with CRLF line terminators >> >> I can convert it with "tr": >> >> $ tr "\r" "\n" < orig.eml > new.eml >> >> $ file new.eml >> new.eml: SMTP mail, ASCII text >> >> $ ./scripts/checkpatch.pl new.eml >> total: 0 errors, 0 warnings, 54 lines checked >> >> new.eml has no obvious style problems and is ready for submission. >> >> Laurent >> > > OK, thank you very much. I shall config my email client again to notice > about it.
You should not use your email client to send patches, you should use "git send-email": http://wiki.qemu.org/Contribute/SubmitAPatch Laurent
