Luiz Capitulino <lcapitul...@redhat.com> writes: > From: Michael Tokarev <m...@tls.msk.ru> > > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints > (with fprintf) something like this: > > warning: could not open /dev/net/tun: no virtual network emulation > > this has 2 issues: > 1) it is not a warning really, it's a fatal error (kvm exits after > that), > 2) there's no indication as of what's actually wrong: printing errno there > is helpful. > > The patch below removes the "warning" prefix, uses %m (since it's linux, > %m is available as format modifier), and changes fprintf() to %qemu_error().
To error_report(), you mean. > Now it prints something like this instead: > > could not configure /dev/net/tun: Device or resource busy > > (there are 2 messages like that in the same function) > > This fixes Debian bug #578154, see > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578154 > > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> Looks good.
