On Fri, Jan 08, 2016 at 10:04:23AM +0100, Paolo Bonzini wrote: > > > On 18/12/2015 13:21, Daniel P. Berrange wrote: > > + > > + if (nfds > SOCKET_MAX_FDS) { > > + error_setg_errno(errp, -EINVAL, > > + "Only %d FDs can be sent, got %zu", > > + SOCKET_MAX_FDS, nfds); > > + return -1; > > + } > > Hi Daniel, > > the second argument here should be positive (s/-EINVAL/EINVAL).
Ok, I'll send followup patch(es) to fix this & the bugs you mention against the other 2 patches. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|