On 09/03/2016 20:59, Eric Blake wrote: > On 03/09/2016 10:47 AM, Paolo Bonzini wrote: >> > On 09/03/2016 18:28, Daniel P. Berrange wrote: >>> >> From: Paolo Bonzini <pbonz...@redhat.com> >> > >> > Reviewing my own patch looks weird. :) >> > >>> >> On Win32 we cannot directly poll on socket handles. Instead we >>> >> create a Win32 event object and associate the socket handle with >>> >> the event. When the event signals readyness we then have to >>> >> use select to determine which events are ready. Creating Win32 >>> >> events is moderately heavyweight, so we don't want todo it >>> >> every time we create a GSource, so this associates a single >>> >> event with a QIOChannel. >>> >> >>> >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> >>> >> --- > Especially when it lacks your S-o-b :)
I'm innocent! :) https://github.com/bonzini/qemu/commit/win32-qio-watch^ Paolo
signature.asc
Description: OpenPGP digital signature