On Wed, Mar 09, 2016 at 10:24:51PM +0100, Paolo Bonzini wrote: > > > On 09/03/2016 20:59, Eric Blake wrote: > > On 03/09/2016 10:47 AM, Paolo Bonzini wrote: > >> > On 09/03/2016 18:28, Daniel P. Berrange wrote: > >>> >> From: Paolo Bonzini <pbonz...@redhat.com> > >> > > >> > Reviewing my own patch looks weird. :) > >> > > >>> >> On Win32 we cannot directly poll on socket handles. Instead we > >>> >> create a Win32 event object and associate the socket handle with > >>> >> the event. When the event signals readyness we then have to > >>> >> use select to determine which events are ready. Creating Win32 > >>> >> events is moderately heavyweight, so we don't want todo it > >>> >> every time we create a GSource, so this associates a single > >>> >> event with a QIOChannel. > >>> >> > >>> >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > >>> >> --- > > Especially when it lacks your S-o-b :) > > I'm innocent! :) > > https://github.com/bonzini/qemu/commit/win32-qio-watch^
Since I made non-trivial changes to this commit, I thought it was corrrect to remove your S-o-b, to avoid claiming that you'd already signed off on the changes I made. Was that not the right thing todo ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|