Eric Blake <ebl...@redhat.com> writes: > On 03/10/2016 03:23 AM, Changlong Xie wrote: [...] >> +++ b/qapi-schema.json >> @@ -4122,3 +4122,21 @@ >> ## >> { 'enum': 'ReplayMode', >> 'data': [ 'none', 'record', 'play' ] } >> + >> +## >> +# @xen-load-devices-state: >> +# >> +# Load the state of all devices from file. The RAM and the block devices >> +# of the VM are not loaded by this command. >> +# >> +# @filename: the file to load the state of the devices from as binary >> +# data. See xen-save-devices-state.txt for a description of the binary >> +# format. >> +# >> +# Returns: Nothing on success >> +# If @filename cannot be opened, OpenFileFailed >> +# If an I/O error occurs while reading the file, IOError > > Drop the whole Returns: paragraph. We have very few distinguished error > categories, and you are not using anything other than a generic error > category here (that is, OpenFileFailed and IOError are NOT valid QMP > error categories).
I have a patch in my tree that cleans up the remaining bad examples. [...]