On 26 March 2016 at 05:57, Pooja Dhannawat <dhannawatpoo...@gmail.com> wrote: > Removing support for DEPTH != 32 from blizzard template header > and file that includes it, as macro DEPTH == 32 only used. > > Reviewed-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Pooja Dhannawat <dhannawatpoo...@gmail.com>
Hi. Apologies for not getting to this patch earlier -- I've been busy with a bunch of other work and the QEMU 2.6 release. In general this patch looks good, but unfortunately it doesn't compile: hw/display/blizzard.c: In function ‘s1d13745_init’: hw/display/blizzard.c:948:5: error: expected ‘;’ before ‘s’ s->line_fn_tab[0] = blizzard_draw_fn_32; ^ In file included from hw/display/blizzard.c:929:0: hw/display/blizzard.c: At top level: hw/display/blizzard_template.h:86:22: error: ‘blizzard_draw_fn_32’ defined but not used [-Werror=unused-variable] static blizzard_fn_t glue(blizzard_draw_fn_, DEPTH)[0x10] = { ^ cc1: all warnings being treated as errors > + assert(surface_bits_per_pixel(surface) == 32) This is because you're missing a semicolon here. It's important to at least compile and preferably also test any patch you send to the list. (Occasionally it's not possible if the code in question requires an obscure host OS or library combination or something, in which case you should note in the patch remarks below the "---" line that you weren't able to compile test.) In this case (and since it took me so long to get back to this patch) I've just fixed up this error and applied the result to target-arm.next. There are a couple of nice further cleanups we can do on top of this to remove blizzard_template.h altogether; I'll post those patches in a moment. thanks -- PMM