> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 20/06/2016 08:26, Pavel Dovgalyuk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >>> From: "Pavel Dovgalyuk" <pavel.dovga...@ispras.ru> > >>> This patch fixes bug with stopping and restarting replay > >>> through monitor. > >>> > >>> Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > >>> --- > > > >> I think that you want to call > >> replay_disable_events... > >> > >>> bdrv_drain_all(); > >> > >> ... after this bdrv_drain_all. > > > > Why? We disable replay events to avoid adding new block requests > > to the queue. How this is related to drain all? > > drain all completes the guest's pending requests. If you disable events > before drain all, doesn't that cause a mismatch between record and replay?
Looks reasonable, thanks. I'll update the patch. What about replay patch for networking? Pavel Dovgalyuk
