On 07/15/2016 03:46 AM, Stefan Hajnoczi wrote: > Renames look like this with git-diff(1) when diff.renames = true is set: > > diff --git a/a b/b > similarity index 100% > rename from a > rename to b > > This raises the "Does not appear to be a unified-diff format patch" > error because checkpatch.pl only considers a diff valid if it contains > at least one "@@" hunk. > > This patch accepts renames and copies too so that checkpatch.pl exits > successfully when a diff only renames/copies files. The git diff > extended header format is described on the git-diff(1) man page. > > Reported-by: Colin Lord <cl...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > scripts/checkpatch.pl | 5 +++++ > 1 file changed, 5 insertions(+)
Reviewed-by: Eric Blake <ebl...@redhat.com> and especially nice since we recommend diff.renames = true in our patch submission guidelines. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
