On Tue, Jul 19, 2016 at 04:42:38PM +0200, Paolo Bonzini wrote: > > > On 19/07/2016 15:47, Colin Lord wrote: > > However, the protocol drivers do tend to see noticeable performance > > benefits. Most of them get modularized in the first three patches of > > this series. This includes the iscsi, glusterfs, ssh, curl, and rbd > > drivers. > > Indeed, but... protocol drivers don't have probes, do they? There is a > distinction between "formats" and "protocols", and only formats need to > be probed for.
IOW, if we only modularized the protocol drivers, then there's no reason to split out the probe code to separate files, so we avoid a whole lot of code churn, and keep all the format drivers largely self contained as today which would be nice. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|