On 07/31/10 16:19, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: >> On 07/30/10 23:08, Aurelien Jarno wrote: >>> Missing braces around the return 0 line. >> >> Half the QEMU code base doesn't have braces around single line if >> statements, including in hw/pci.c. Adding braces here would be inconsistent. >> > > If we follow the coding style in new patches, it will eventually become > consistent. >
If you want that, please do it in a separate patch for the entire file, otherwise it will never become consistent. However it doesn't change the issue either that putting braces around a single line like this is bad coding style. Jes
