On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: > On 07/31/10 16:19, Aurelien Jarno wrote: > > On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: > >> On 07/30/10 23:08, Aurelien Jarno wrote: > >>> Missing braces around the return 0 line. > >> > >> Half the QEMU code base doesn't have braces around single line if > >> statements, including in hw/pci.c. Adding braces here would be > >> inconsistent. > >> > > > > If we follow the coding style in new patches, it will eventually become > > consistent. > > > > If you want that, please do it in a separate patch for the entire file, > otherwise it will never become consistent. However it doesn't change the > issue either that putting braces around a single line like this is bad > coding style.
We got this discussions numerous times, and I am not going to start it again. If you want to see the patch applied, just follow the rules. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurel...@aurel32.net http://www.aurel32.net
