On 06.09.2016 22:55, Thomas Huth wrote: > On 06.09.2016 22:23, Paolo Bonzini wrote: >> >> >> On 06/09/2016 21:35, Thomas Huth wrote: >>> D'oh! I'll have a look... >>> >>>>> I also see warnings on non-KVM hosts during 'make check' which seem >>>>> to be produced by this new test: >>>>> >>>>> TEST: tests/boot-serial-test... (pid=2836) >>>>> /i386/boot-serial/isapc: >>>>> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit >>>>> 1] >>> That happens because the test is running QEMU with the isapc machine. I >>> also get that warning message if I simply run the following on the >>> command line: >>> >>> $ qemu-system-x86_64 -M isapc >>> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit 1] >>> >>> So the warning is likely there since quite a while already, just nobody >>> is running with -M isapc nowadays anymore, so nobody noticed this ... >>> Does anybody have got a clue how to fix that warning? >> >> Implement vme... :) > > Hmmm, I was rather looking for an easier solution. I think I also found > one: By using "-cpu qemu32", the warning does not occur anymore...
David, since you likely got to respin this pull request anyway, could you please squash the following patch into my "tests: Check serial output of firmware boot of some machines" patch? This silences the warning about the unsupported vme TCG feature: diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index b36c6bf..d98c564 100644 --- a/tests/boot-serial-test.c +++ b/tests/boot-serial-test.c @@ -29,10 +29,10 @@ static testdef_t tests[] = { { "ppc64", "ppce500", "", "U-Boot" }, { "ppc64", "prep", "", "Open Hack'Ware BIOS" }, { "ppc64", "pseries", "", "Open Firmware" }, - { "i386", "isapc", "-device sga", "SGABIOS" }, + { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" }, { "i386", "pc", "-device sga", "SGABIOS" }, { "i386", "q35", "-device sga", "SGABIOS" }, - { "x86_64", "isapc", "-device sga", "SGABIOS" }, + { "x86_64", "isapc", "-cpu qemu32 -device sga", "SGABIOS" }, { "x86_64", "q35", "-device sga", "SGABIOS" }, { "s390x", "s390-ccw-virtio", "-nodefaults -device sclpconsole,chardev=serial0", "virtio device" }, Thanks, Thomas