On Tue, 2016-09-06 at 23:09 +0200, Thomas Huth wrote: > The bad commit is: "ppc: Speed up load/store multiple" > > There are two "#if defined(HOST_WORDS_BIGENDIAN)" sections in this patch > which are both bad: The memcpy tries to copy 32-bit values into 64-bit > registers, which of course does not work (unless you compile this code > for a 32-bit host only where the size of a gpr is only 32-bit).
The instruction does that. It only copies 32-bits. I think it's correct. > I'd suggest to remove the "#if defined(HOST_WORDS_BIGENDIAN)" part and > use cpu_to_be32() and friends instead of the bswap32() here? I tried that but it prevents the faster memcpy, the whole point was to speed things up... Cheers, Ben.
