On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote: > Kevin Wolf's advice: > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
IIUC, what Stefan meant is to write a simple descriptive commit message that explains why this change is necessary -- the above URL might have context, but having it spelled out in the Git commit message will be useful when someone is examining Git history offline. I think Stefan was looking for something like (came up with this after reading the above thread): QAPI: BlockdevOptionsReplication: Clarify 'top-id' parameter usage In primary mode, the replication driver will ignore 'top-id' parameter, thus it must not be supplied. Explicitly spell that out in the QAPI schema for BlockdevOptionsReplication. > Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> > Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> > Signed-off-by: Wang WeiWei <wangww.f...@cn.fujitsu.com> > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > Signed-off-by: Gonglei <arei.gong...@huawei.com> > --- > qapi/block-core.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ada3202..a605107 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2184,7 +2184,8 @@ > # @mode: the replication mode > # > # @top-id: #optional In secondary mode, node name or device ID of the root > -# node who owns the replication node chain. Ignored in primary mode. > +# node who owns the replication node chain. Must not be given in > +# primary mode. > # > # Since: 2.8 > ## > -- > 2.7.4 > > > > -- /kashyap
