This is v2, should be included in the subject line. Am 30.09.2016 um 10:53 hat Wang WeiWei geschrieben: > Kevin Wolf's advice: > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html > > Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> > Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> > Signed-off-by: Wang WeiWei <wangww.f...@cn.fujitsu.com> > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > Signed-off-by: Gonglei <arei.gong...@huawei.com> > --- > qapi/block-core.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ada3202..a605107 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2184,7 +2184,8 @@ > # @mode: the replication mode > # > # @top-id: #optional In secondary mode, node name or device ID of the root > -# node who owns the replication node chain. Ignored in primary mode. > +# node who owns the replication node chain. Must not be given in > +# primary mode. > # > # Since: 2.8 > ##
As I already wrote for v1: The matching code in block/replication.c is missing to actually error out if the option is given in primary mode. Kevin
