On Sun, Aug 22, 2010 at 7:28 PM, Anthony Liguori <anth...@codemonkey.ws> wrote: > On 08/22/2010 01:56 PM, Blue Swirl wrote: >>> >>> Why is this even still being discussed? What problem are people actually >>> trying to solve? >>> >>> Can someone point to a bug in QEMU that's been caused because of >>> CODING_STYLE or the fact that some patches don't adhere to it? >>> >> >> 7b1df88f284f462ecb236931ad863a815f243195 >> > > That's a hell of a bug :-)
Yeah. IIRC I almost dismissed the warning from clang as false positive because I just couldn't see any bug. >>> I don't see a problem with the way things are today. >>> >> >> There is the problem that some patch submitters are reminded of >> CODING_STYLE while others aren't. > > I still think we spend far too much time discussing this on list. While I > stand corrected that we've ever had a bug because of this, I have a hard > time believing this is anywhere in the top 10 list of issues that we have. When an outsider submits a patch which gets reviewed, CODING_STYLE issues can almost certainly be expected. The other frequent issues (for example memory management) should be addressed by HACKING.