On Sun, Aug 22, 2010 at 8:09 PM, Avi Kivity <a...@redhat.com> wrote: > On 08/22/2010 09:56 PM, Blue Swirl wrote: >> >>> Can someone point to a bug in QEMU that's been caused because of >>> CODING_STYLE or the fact that some patches don't adhere to it? >> >> 7b1df88f284f462ecb236931ad863a815f243195 > > How was this bug caused by CODING_STYLE? In fact, if CODING_STYLE was > applied correctly then this bug would stand out much more: > > if (...) { > /* .... */; > } > return; > > or be completely eliminated: > > if (...) { > /* .... */; > return; > }
Exactly. It was caused by code not adhering to CODING_STYLE (maybe because it didn't exist at the time).