On 10/24/2016 09:54 PM, Max Reitz wrote: > Currently, curl defines its own constant SECTOR_SIZE. There is no > advantage over using the global BDRV_SECTOR_SIZE, so drop it. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > block/curl.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com>
(Can curl technically be used to access single-byte granularity? I
suppose that would be a larger patch, though, to implement the right
callbacks).
> + DPRINTF("CURL (AIO): Reading %llu at %zd (%s)\n",
> + (acb->nb_sectors * BDRV_SECTOR_SIZE), start, state->range);
Eww. start is seriously limited to size_t rather than off_t? Doesn't
that cripple us to a maximum of 4G files on 32-bit hosts? But unrelated
to this patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
