On Fri, 9 Dec 2016 18:06:50 -0200 Eduardo Habkost <ehabk...@redhat.com> wrote:
> Now my question is: what should we do in 2.8.1? > > 1) Change the rules and apply "[PATCH] qdev: fix the order compat > and global properties are applied" I don't think changing the rules is something that should be done for a stable release. > 2) Fix only virtio-pci (apply a new version of "[PATCH] virtio: > fix HW_COMPAT_2_6 macro for virtio-*-pci drivers") This has the benefit of fixing exactly one problem in an easily reviewable patch... > 3) Apply this hack so we fix all compat_props cases without > changing ordering rules. (And then change the ordering rules > in 2.9) ...while this has the benefit of fixing the complete class of problems. I'd say 2 or 3, but I'd favour 3. 2.8.1 will not be released next week, so we have enough time to verify that we don't introduce any new breakage.