"Michael S. Tsirkin" <m...@redhat.com> writes: > On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: >> v7 changelog: >> 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >> please take a look, there is detailed description in the patch. >> 2. add the R-b from Hannes Reinecke >> >> Test: >> 1. make check: pass >> 2. After applied all the patch, command line test for all the >> affected devices, just make sure device realize process is ok, >> no crash, but no further use of device. > > Consider the megasas device for example, don't you > need to test that the change actually does what > it's intended to do?
For better or worse, that's a higher bar than we commonly require for refactorings. [...]
