On Wed, Jan 18, 2017 at 11:16:07PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 18, 2017 at 09:04:03PM +0000, Peter Maydell wrote: > > On 18 January 2017 at 20:55, Michael S. Tsirkin <m...@redhat.com> wrote: > > > All users include the trailing ;, let's require that > > > so that uses such as if (a) QEMU_BUILD_BUG_ON(); do not > > > produce unexpected results. > > > > When would it ever make sense for a build-time > > assert to be the only thing inside a runtime > > conditional anyway? > > > > thanks > > -- PMM > > What do I know? Do you want to keep the trailing ; in there? > I can drop this patch.
Maybe a better justification: QEMU_BUILD_BUG_ON(0) QEMU_BUILD_BUG_ON(0) looks ugly but is allowed by the current implementation. Let's drop the trailing ; within the macro to make sure all users include the ';'. > -- > MST