On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Name same things the same, different things differently. > > * qemu_strtol()'s parameter @nptr is called @p in > check_strtox_error(). Rename the latter. > > * qemu_strtol()'s parameter @endptr is called @next in > check_strtox_error(). Rename the latter. > > * qemu_strtol()'s variable @p is called @endptr in > check_strtox_error(). Rename both to @ep. > > * qemu_strtol()'s variable @err is *negative* errno, > check_strtox_error()'s parameter @err is *positive*. Rename the > latter to @eno.
Whether or not you rename @eno based on Paolo's comments, > > Same for qemu_strtoul(), qemu_strtoi64(), qemu_strtou64(), of course. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > util/cutils.c | 42 +++++++++++++++++++++--------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
