On Tue, Oct 05, 2010 at 06:42:34PM +0200, Alexander Graf wrote: > > On 02.10.2010, at 20:17, John Clark wrote: > > >> Hi, > >> > >> Alex: > >> I think you've missed the part of the patch that renames the _lo -> _hi. > >> As John says, qemu had the hi/lo parts reversed when reading 4xx TLB regs. > >> > >> Except for the comments and the define, the patch looks good to me. > >> John, please also add a Signed-off-by line. > >> > >> Cheers > > > > Ok, I have removed the superfluous comments, added defines for magic > > numbers, added braces to conform to the QEMU coding style guidelines, > > and regression tested it in my system. Patch included below. > > > > Thanks. > > > > - John > > > > Signed-off-by: John Clark <clar...@runbox.com> > > Signed-off-by: Alexander Graf <ag...@suse.de>
Applied, thanks John and Alex. Cheers