Samual, Jan: Can you just take 1-3 of this series; 4 has a problem; * Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > > > Working up the stack, this replaces the slirp_socket_load/save > > with VMState definitions. > > > > A place holder for IPv6 support is added as a comment; it needs > > testing once the rest of the IPv6 code is there. > > > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > Reviewed-by: Juan Quintela <quint...@redhat.com> > > > > +/* Win has a signed family number */ > > +#define VMSTATE_SS_FAMILY(f, s) VMSTATE_INT16(f, s) > > Great! > Just hope that there is no 32000 families soon :-)
Actually; that's a problem; it turns out FreeBSD has a char for it's family type rahter than the uint16 that linux and windows have. I need to think hth to abstract that. Dave > > > > +#if 0 > > + /* Untested: Needs checking by someone with IPv6 test */ > > + VMSTATE_BUFFER_TEST(sin6.sin6_addr, union slirp_sockaddr, > > + slirp_family_inet6), > > + VMSTATE_UINT16_TEST(sin6.sin6_port, union slirp_sockaddr, > > + slirp_family_inet6), > > + VMSTATE_UINT32_TEST(sin6.sin6_flowinfo, union slirp_sockaddr, > > + slirp_family_inet6), > > + VMSTATE_UINT32_TEST(sin6.sin6_scope_id, union slirp_sockaddr, > > + slirp_family_inet6), > > +#endif > > I think this is wrong, we have different fieldbs depending in if it is > ipv6 or not? > > Later, Juan. > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
